Skip to content

Enable all fundamental state, actions and reducers in web component#728

Merged
loiswells97 merged 15 commits intomainfrom
issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component
Nov 10, 2023
Merged

Enable all fundamental state, actions and reducers in web component#728
loiswells97 merged 15 commits intomainfrom
issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component

Conversation

@create-issue-branch
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Oct 31, 2023

closes #727

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component October 31, 2023 11:15 Inactive
@github-actions
Copy link

github-actions bot commented Oct 31, 2023

@github-actions
Copy link

github-actions bot commented Oct 31, 2023

@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component October 31, 2023 16:56 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 1, 2023 11:48 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Nov 1, 2023

@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 1, 2023 12:14 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Nov 1, 2023

@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 1, 2023 14:27 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Nov 1, 2023

@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 3, 2023 14:04 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 6, 2023 12:09 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 6, 2023 12:11 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Nov 6, 2023

@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 6, 2023 12:13 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Nov 6, 2023

@loiswells97 loiswells97 marked this pull request as ready for review November 6, 2023 12:26
sra405
sra405 reviewed Nov 6, 2023
View reviewed changes
src/hooks/useProject.js
Comment on lines +56 to +64
if (code) {
const project = {
name: "Blank project",
type: "python",
components: [{ name: "main", extension: "py", content: code }],
};
dispatch(setProject(project));
return;
}
Copy link
Contributor

@sra405 sra405 Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 might want to think about how we can expand this to HTML code too - not for this but a nice thing to think about 😁

sra405
sra405 previously approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@sra405 sra405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 merge it up and have a poke around staging to ensure the standalone still works as expected with the useProjectPersistence hook. It'll give us what we need to start to pull projects from editor-api but worth keeping an eye on the token scope and auto refresh functionality

@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 10, 2023 09:08 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 10, 2023 09:23 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 10, 2023 09:48 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 10, 2023 12:25 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 10, 2023 12:26 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 10, 2023 12:57 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component November 10, 2023 13:09 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Nov 10, 2023

@github-actions
Copy link

github-actions bot commented Nov 10, 2023

sra405
sra405 approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@sra405 sra405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just to be sure

@loiswells97 loiswells97 merged commit 9c5846b into main Nov 10, 2023
@loiswells97 loiswells97 deleted the issues/727-Enable_all_fundamental_state_actions_and_reducers_in_web_component branch November 10, 2023 13:21
floehopper added a commit that referenced this pull request May 28, 2024
@floehopper
Remove unused ComponentStore
69bf0a2 
This was introduced in #96, but never used. I suspect the `import store
from "./app/store"` statement in `src/web-component.js` was intended to
import it, but it used the wwrong filename.

`ComponentStore` was later effectively replaced by `WebComponentStore`
in #728.
@floehopper floehopper mentioned this pull request May 28, 2024
Merged
floehopper added a commit that referenced this pull request May 28, 2024
@floehopper
Remove unused ComponentStore
58f6d15 
This was introduced in #96, but never used. I suspect the `import store
from "./app/store"` statement in `src/web-component.js` was intended to
import it, but it used the wrong filename.

`ComponentStore` was later effectively replaced by `WebComponentStore`
in #728.
floehopper added a commit that referenced this pull request May 28, 2024
@floehopper
Remove unused ComponentStore
bb99d9f 
This was introduced in #96, but never used. I suspect the `import store
from "./app/store"` statement in `src/web-component.js` was intended to
import it, but it used the wrong filename.

`ComponentStore` was later effectively replaced by `WebComponentStore`
in #728.
floehopper added a commit that referenced this pull request May 28, 2024
@floehopper
Remove unused ComponentStore (#1023)
ca69c29 
This was introduced in #96, but never used. I suspect the `import store
from "./app/store"` statement in `src/web-component.js` was intended to
import it, but it used the wrong filename.

`ComponentStore` was later effectively replaced by `WebComponentStore`
in #728.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sra405 sra405 sra405 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable all fundamental state, actions and reducers in web component

2 participants

@sra405 @loiswells97